Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support native bound cheatcode #9154

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

feat: support native bound cheatcode #9154

wants to merge 25 commits into from

Conversation

malik672
Copy link
Contributor

closes #8788

@malik672 malik672 changed the title native feat: support native bound cheatcode Oct 21, 2024
@malik672
Copy link
Contributor Author

@grandizzy @jenpaff I should be done this but I think the addition of the max and min bound have broken the fuzzer

@grandizzy
Copy link
Collaborator

@grandizzy @jenpaff I should be done this but I think the addition of the max and min bound have broken the fuzzer

thank you @malik672!, will check and get back

@grandizzy
Copy link
Collaborator

@malik672 indeed it changes the way edge values are generated, for example for failing test should_not_shrink_fuzz_failure here https://github.com/foundry-rs/foundry/actions/runs/11459821558/job/31885189020?pr=9154#step:12:390 it is now failing with U256::MAX - 1 instead U256::MAX which is not a big issue but can be avoided (and current behavior preserved) if min / max bounds made as options

@grandizzy grandizzy marked this pull request as draft October 23, 2024 06:49
@malik672
Copy link
Contributor Author

malik672 commented Oct 23, 2024 •
edited
Loading

@malik672 indeed it changes the way edge values are generated, for example for failing test should_not_shrink_fuzz_failure here https://github.com/foundry-rs/foundry/actions/runs/11459821558/job/31885189020?pr=9154#step:12:390 it is now failing with U256::MAX - 1 instead U256::MAX which is not a big issue but can be avoided (and current behavior preserved) if min / max bounds made as options

@grandizzy @jenpaff I should be done this but I think the addition of the max and min bound have broken the fuzzer

thank you @malik672!, will check and get back

@grandizzy made them as options broke more of the CI test :)

@mds1 mds1 mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cheatcodes): support native bound cheatcode
2 participants
@malik672 @grandizzy